Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226320573
  
    --- Diff: python/minifi/__init__.py ---
    @@ -66,9 +66,9 @@ def setBase(self, proc):
         def get(self, session):
             ff = self._minifi.get(self._instance.get_instance(),self._flow, 
session)
             if ff:
    --- End diff --
    
    Yeah i tend to avoid ternary operators in general since my experience with 
production code has always led maintainers at some point to result in error. 
Looks great -- but more errors than positives in my experience I'm afraid. 


---

Reply via email to