[
https://issues.apache.org/jira/browse/NIFI-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658047#comment-16658047
]
ASF GitHub Bot commented on NIFI-5728:
--------------------------------------
GitHub user bdesert opened a pull request:
https://github.com/apache/nifi/pull/3098
NIFI-5728 XML Writer to populate record tag name properly
All the changes are tested against
- "Use Schema Text" (regression)
- "AvroSchemaRegistry" Controller Service
- "Hortonworks Schema Registry" Controller Service (docker).
Also added Test Case to handle scenario when schema name in xxxRegistry
Controller Service doesn't mach "name" field of the root record in schema text.
-------
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bdesert/nifi NIFI-5728_XMLWriter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3098.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3098
----
commit 268ae74deeaf0228fb07cf50c3dd343ff9fb7e9f
Author: Ed B <eberezitsky@...>
Date: 2018-10-21T01:42:21Z
NIFI-5728 XML Writer to populate record tag name properly
----
> Inconsistent behavior in XMLRecordSetWriter for Root Record Tag
> ---------------------------------------------------------------
>
> Key: NIFI-5728
> URL: https://issues.apache.org/jira/browse/NIFI-5728
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.7.1
> Reporter: Ed Berezitsky
> Assignee: Ed Berezitsky
> Priority: Major
>
> In XMLRecordSetWriter:
> When used with "Use Schema Text" and "Name of Record Tag" is empty (so record
> name should be used to wrapping XML tag) - works correctly.
> When used with Schema Registry and "Name of Record Tag" is empty - it doesn't
> write record name, but uses schema name instead. I believe this inconsistency
> is coming from the fact that when schema in a writer defined by "Use Schema
> Text" - it doesn't have a name and then name is taken from a record. But when
> it comes from registry - it simply uses schema idetifier:
> {code:java}
> recordSchema.getIdentifier().getName();
> {code}
> IMO root record name should be used in this case instead of schema name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
