Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/3085
  
    @patricker you do have a good point... interestingly, though, that's not a 
bug introduced in your PR, as the call to `readLine()` that existed before 
would also never check the max buffer size. the docs say "Specifies the maximum 
amount of data to buffer (per file or per line, depending on the Evaluation 
Mode)" but unless I'm missing something, it has never been enforced per-line. 
Also, I did put up a PR, https://github.com/apache/nifi/pull/3100, that 
addresses the performance concern and in that PR, it does actually enforce the 
max buffer size (as a 'weak limit'), which until now I had not noticed that we 
were previously not doing.


---

Reply via email to