Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3041#discussion_r228542809
  
    --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/pom.xml ---
    @@ -147,6 +147,12 @@
                 <version>2.2.1</version>
                 <scope>test</scope>
             </dependency>
    +        <dependency>
    +            <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-solr-client-api</artifactId>
    +            <version>1.8.0-SNAPSHOT</version>
    +            <scope>compile</scope>
    --- End diff --
    
    This should be provided scope, using compile scope would mean the 
nifi-solr-client-api JAR would be packaged into two different NARs (the API NAR 
and the processors NAR) and at runtime it should only be in the API NAR. 
    
    This relates to the other comment that the nifi-solr-nar pom needs to be 
updated to change its parent from standard services to the 
nifi-solr-client-api-nar.
    
    I'm not in a state to try it right now, but I would suspect that running a 
full build of this branch you would be able to create a SolrClientService, but 
not assign it in one of the Solr processors.



---

Reply via email to