Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229300368
  
    --- Diff: docker/test/integration/minifi/test/__init__.py ---
    @@ -142,7 +147,7 @@ def check_output(self, timeout=5):
             self.wait_for_output(timeout)
             self.log_nifi_output()
     
    -        return self.output_validator.validate()
    +        return self.output_validator.validate() & ~self.segfault
    --- End diff --
    
    I'm not a python developer ( first time were recent PRs ) -- after doing 
some reading I'm guessing the boolean operators are preferred here? It works 
due to autoboxing as it's a very simple expression; however, your statement 
"left argument is a boolean" implies that it is not common to use the bitwise 
operators here? 


---

Reply via email to