Github user arpadboda commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r230801807
  
    --- Diff: libminifi/CMakeLists.txt ---
    @@ -141,11 +141,14 @@ endif()
     SET (LIBMINIFI core-minifi PARENT_SCOPE)
     
     if (ENABLE_PYTHON)
    -if (NOT APPLE)
     #### shared
     
     add_library(core-minifi-shared SHARED ${SOURCES})
    -target_link_libraries(core-minifi-shared ${CMAKE_DL_LIBS} uuid-shared 
yaml-cpp)
    +if (APPLE)
    --- End diff --
    
    I strongly agree, but in that case Python related tests (the ones that 
don't transport, just create instance, processor, flow files) could also be 
added to cover that. 


---

Reply via email to