Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3133#discussion_r231582876 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java --- @@ -164,6 +164,71 @@ public ValidationResult validate(final String subject, final String input, final .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY) .build(); + public static final PropertyDescriptor MIN_IDLE = new PropertyDescriptor.Builder() + .displayName("Minimum Idle Connections") + .name("dbcp-mim-idle-conns") + .description("The minimum number of connections that can remain idle in the pool, without extra ones being " + + "created, or zero to create none.") + .defaultValue("0") + .required(true) + .addValidator(StandardValidators.INTEGER_VALIDATOR) + .build(); + + public static final PropertyDescriptor MAX_IDLE = new PropertyDescriptor.Builder() + .displayName("Max Idle Connections") + .name("dbcp-max-idle-conns") + .description("The maximum number of connections that can remain idle in the pool, without extra ones being " + + "released, or negative for no limit.") + .defaultValue("8") + .required(true) + .addValidator(StandardValidators.INTEGER_VALIDATOR) + .build(); + + public static final PropertyDescriptor MAX_CONN_LIFETIME = new PropertyDescriptor.Builder() + .displayName("Max Connection Lifetime") + .name("dbcp-max-conn-lifetime") + .description("The maximum lifetime in milliseconds of a connection. After this time is exceeded the " + + "connection will fail the next activation, passivation or validation test. A value of zero or less " + + "means the connection has an infinite lifetime.") + .defaultValue("-1") + .required(true) + .addValidator(CUSTOM_TIME_PERIOD_VALIDATOR) + .build(); + + public static final PropertyDescriptor EVICTION_RUN_PERIOD = new PropertyDescriptor.Builder() + .displayName("Time Between Eviction Runs") + .name("dbcp-time-between-eviction-runs") + .description("The number of milliseconds to sleep between runs of the idle connection evictor thread. When " + + "non-positive, no idle connection evictor thread will be run.") + .defaultValue("-1") + .required(true) + .addValidator(CUSTOM_TIME_PERIOD_VALIDATOR) + .build(); + + public static final PropertyDescriptor MIN_EVICTABLE_IDLE_TIME = new PropertyDescriptor.Builder() + .displayName("Minimum Evictable Idle Time") + .name("dbcp-min-evictable-idle-time") + .description("The minimum amount of time a connection may sit idle in the pool before it is eligible for eviction.") + .defaultValue("1800 secs") + .required(true) + .addValidator(CUSTOM_TIME_PERIOD_VALIDATOR) --- End diff -- The validator supports expression language, so I think these properties should support expression language at the Variable Registry level
---