[ 
https://issues.apache.org/jira/browse/NIFI-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682110#comment-16682110
 ] 

ASF GitHub Bot commented on NIFI-5810:
--------------------------------------

GitHub user bdesert opened a pull request:

    https://github.com/apache/nifi/pull/3164

    NIFI-5810 Add UserName EL support to JMS processors

    Adding EL support to a property "User Name" to ConsumeJMS and PublishJSM
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bdesert/nifi NIFI-5810_JMS_EL

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3164
    
----
commit 5013dfff04bff154f8e1fc150e096a3ab6098a49
Author: Ed B <eberezitsky@...>
Date:   2018-11-10T00:27:10Z

    NIFI-5810 Add UserName EL support to JMS processors
    
    Adding EL support to a property "User Name" to ConsumeJMS and PublishJSM

----


> Add EL support to User Name property in ConsumeJMS and PublishJMS
> -----------------------------------------------------------------
>
>                 Key: NIFI-5810
>                 URL: https://issues.apache.org/jira/browse/NIFI-5810
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Ed Berezitsky
>            Assignee: Ed Berezitsky
>            Priority: Major
>
> ConsumeJMS and PublishJMS don't support EL for user name property.
> As a result, username should be hard coded, so updating this property per 
> environment makes flows not version-able.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to