[ https://issues.apache.org/jira/browse/MINIFICPP-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688109#comment-16688109 ]
ASF GitHub Bot commented on MINIFICPP-676: ------------------------------------------ GitHub user arpadboda opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/440 MINIFICPP-676 - Cleanup and fix serializable interface implementation Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/arpadboda/nifi-minifi-cpp MINIFICPP-676 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/440.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #440 ---- commit cf32a07d7a4b7082a7bc956ea5aa61b343789b81 Author: Arpad Boda <aboda@...> Date: 2018-11-14T16:06:17Z MINIFICPP-676 - Cleanup and fix serializable interface implementation ---- > Cleanup and fix serializable interface implementation > ----------------------------------------------------- > > Key: MINIFICPP-676 > URL: https://issues.apache.org/jira/browse/MINIFICPP-676 > Project: NiFi MiNiFi C++ > Issue Type: Improvement > Reporter: Arpad Boda > Assignee: Arpad Boda > Priority: Minor > > Serializable interface contains a couple of issues: > Type-unsafe template functions > Code duplication > Needless functions > The goal of this ticket is to make the interface cleaner and simpler. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)