[ https://issues.apache.org/jira/browse/NIFI-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688398#comment-16688398 ]
ASF GitHub Bot commented on NIFI-5822: -------------------------------------- GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3171 NIFI-5822: Ensure that we don't call FlowController.getControllerServ… …iceProvider() before the ControllerServiceProvider has been initialized Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-5822 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3171 ---- commit 6aaf3ed25e17523071b3d4e2dd400a43685f873a Author: Mark Payne <markap14@...> Date: 2018-11-15T17:33:03Z NIFI-5822: Ensure that we don't call FlowController.getControllerServiceProvider() before the ControllerServiceProvider has been initialized ---- > ControllerServices not available during @OnScheduled > ---------------------------------------------------- > > Key: NIFI-5822 > URL: https://issues.apache.org/jira/browse/NIFI-5822 > Project: Apache NiFi > Issue Type: Bug > Affects Versions: 1.8.0 > Reporter: Peter Wicks > Priority: Blocker > Fix For: 1.9.0 > > > If a processor tries to load a ControllerService during `@OnScheduled`, then > `context.getControllerService` contains a null reference to > `controllerServiceProvider`. I traced this back to > `StandardProcessScheduler.startProcessor`, and the reference to > `controllerServiceProvider` is also `null` here. `ExecuteSQL` acquires it's > connection during `@OnScheduled`. > But once we reach `onTrigger`, everything is fine and you can retrieve a > controller service without issue -- This message was sent by Atlassian JIRA (v7.6.3#76005)