[ https://issues.apache.org/jira/browse/MINIFICPP-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700427#comment-16700427 ]
ASF GitHub Bot commented on MINIFICPP-685: ------------------------------------------ Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/449#discussion_r236664502 --- Diff: libminifi/include/core/ConfigurableComponent.h --- @@ -153,14 +153,14 @@ class ConfigurableComponent { * * @return vector of property keys */ - std::vector<std::string> getDynamicPropertyKeys(); + std::vector<std::string> getDynamicPropertyKeys() const; /** * Returns a vector all properties * * @return map of property keys to Property instances. */ - std::map<std::string, Property> getProperties(); + std::map<std::string, Property> getProperties() const; --- End diff -- Did you not change to const ref map because current implementations expect to modify this map? > Improve const correctness of property getters > --------------------------------------------- > > Key: MINIFICPP-685 > URL: https://issues.apache.org/jira/browse/MINIFICPP-685 > Project: NiFi MiNiFi C++ > Issue Type: Improvement > Reporter: Arpad Boda > Assignee: Arpad Boda > Priority: Minor > Fix For: 0.6.0 > > > Most of property getters are non-const, but they should be. > Virtual functions shouldn't be modified in minor release, the rest can be > fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)