[
https://issues.apache.org/jira/browse/MINIFICPP-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708591#comment-16708591
]
ASF GitHub Bot commented on MINIFICPP-404:
------------------------------------------
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/454#discussion_r238631364
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -325,6 +325,12 @@ void
YamlConfiguration::parseRemoteProcessGroupYaml(YAML::Node *rpgNode, core::P
}
}
}
+ } else if (transport_protocol == "RAW") {
+ group->setTransportProtocol(transport_protocol);
+ } else {
+ std::stringstream stream;
+ stream << "Invalid transport protocol " << transport_protocol;
+ throw minifi::Exception(ExceptionType::SITE2SITE_EXCEPTION,
stream.str().c_str());
--- End diff --
This is fine, however makes me wonder why don't we have string param ctr.
for minifi::Exception as we convert to the const char* to string anyway in the
current ctr.
> HTTP Proxy Support for HTTP Site to Site
> ----------------------------------------
>
> Key: MINIFICPP-404
> URL: https://issues.apache.org/jira/browse/MINIFICPP-404
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Affects Versions: 0.6.0
> Reporter: bqiu
> Assignee: Mr TheSegfault
> Priority: Minor
> Fix For: 0.6.0
>
>
> HTTP Proxy Support for HTTP Site to Site
> http://nifi.apache.org/docs/nifi-docs/html/user-guide.html#configure-site-to-site-client-nifi-instance.
> support for this in YAML config via
> https://github.com/apache/nifi-minifi/blob/master/minifi-docs/src/main/markdown/System_Admin_Guide.md#remote-process-groups-1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
