Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239117254
--- Diff: libminifi/include/Exception.h ---
@@ -60,16 +60,17 @@ class Exception : public std::exception {
public:
// Constructor
/*!
- * Create a new flow record
+ * Create a new exception
*/
- Exception(ExceptionType type, const char *errorMsg)
+ Exception(ExceptionType type, std::string errorMsg)
: _type(type),
- _errorMsg(errorMsg) {
+ _errorMsg(std::move(errorMsg)) {
}
+
// Destructor
- virtual ~Exception() throw () {
+ virtual ~Exception() noexcept {
--- End diff --
I didn't notice that throw was here. Odd choice. The compiler usually
generates an implicit noexcept unless told otherwise, so I'm tempted to do a
little more testing of this across compilers. I'll do this before merge.
---
