[ 
https://issues.apache.org/jira/browse/NIFI-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718360#comment-16718360
 ] 

ASF GitHub Bot commented on NIFI-5890:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3214#discussion_r240856001
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java
 ---
    @@ -404,7 +404,7 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
                                                 reason = 
itemNode.findPath("reason").asText();
                                             }
                                             errorReason = reason;
    -                                        logger.error("Failed to process {} 
due to {}, transferring to failure",
    +ta                                        logger.error("Failed to process 
{} due to {}, transferring to failure",
    --- End diff --
    
    I believe this change is not intentional.


> Add Timestamp -> Date conversion support to DataTypeUtils
> ---------------------------------------------------------
>
>                 Key: NIFI-5890
>                 URL: https://issues.apache.org/jira/browse/NIFI-5890
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>    Affects Versions: 1.8.0
>            Reporter: Mike Thomsen
>            Assignee: Mike Thomsen
>            Priority: Major
>
> Timestamp to Date conversion fails with following Exception with 
> rel/nifi-1.8.0 branch:
> {code}
> [ERROR] 
> testTimestampToDate(org.apache.nifi.serialization.record.TestDataTypeUtils)  
> Time elapsed: 0.008 s  <<< ERROR!
> org.apache.nifi.serialization.record.util.IllegalTypeConversionException: 
> Cannot convert value [2018-12-12 10:45:26.478] of type class 
> java.sql.Timestamp to Date for field null
>         at 
> org.apache.nifi.serialization.record.TestDataTypeUtils.testTimestampToDate(TestDataTypeUtils.java:67)
> {code}
> But NIFI-5333 added supporting this. This JIRA adds an unit test case to 
> assert that conversion works.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to