arpadboda commented on a change in pull request #484: MINIFICPP-735: Fix issues
with delimiter, make changes to facilitate …
URL: https://github.com/apache/nifi-minifi-cpp/pull/484#discussion_r257525116
##########
File path: libminifi/src/processors/TailFile.cpp
##########
@@ -287,14 +288,36 @@ void TailFile::onTrigger(core::ProcessContext *context,
core::ProcessSession *se
std::string baseName = _currentTailFileName.substr(0, found);
std::string extension = _currentTailFileName.substr(found + 1);
- if (!this->_delimiter.empty()) {
- char delim = this->_delimiter.c_str()[0];
+ if (!delimiter_.empty()) {
+ char delim = delimiter_.c_str()[0];
+ if (delim == '\\') {
+ if (delimiter_.size() > 1) {
+ switch (delimiter_.c_str()[1]) {
+ case 'r':
+ delim = '\r';
+ break;
+ case 't':
+ delim = '\t';
+ break;
+ case 'n':
+ delim = '\n';
+ break;
+ case '\\':
+ delim = '\\';
+ break;
+ default:
+ // previous behavior
Review comment:
Maybe a log statement here?
This seems to be a configuration error as the delimiter string is longer
than 1, but it doesn't contain any escaped char we support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
