arpadboda commented on a change in pull request #482: Minificpp 658 - Port Raw Site to Site to C URL: https://github.com/apache/nifi-minifi-cpp/pull/482#discussion_r259831743
########## File path: nanofi/examples/transmit_payload.c ########## @@ -0,0 +1,77 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <stdio.h> +#include <stdlib.h> +#include <string.h> + +#include "api/nanofi.h" +#include "core/log.h" +#include "sitetosite/CPeer.h" +#include "sitetosite/CRawSocketProtocol.h" + +int main(int argc, char **argv) { + + if (argc < 4) { + printf("Error: must run ./transmit_payload <host> <port> <nifi port>\n"); + exit(1); + } + + set_log_level(info); + + char *host = argv[1]; + char *port_str = argv[2]; + char *nifi_port_str = argv[3]; + + uint16_t port_num = atoi(port_str); + + struct SiteToSiteCPeer peer; + + initPeer(&peer, NULL, host, port_num, ""); + + struct CRawSiteToSiteClient protocol; + + initRawClient(&protocol, &peer); + + setPortId(&protocol, nifi_port_str); + + const char * payload = "Test MiNiFi payload"; + + attribute attribute1; + + attribute1.key = "some_key"; + const char * attr_value = "some value"; + attribute1.value = (void *)attr_value; + attribute1.value_size = strlen(attr_value); + + attribute_set as; + as.size = 1; + as.attributes = &attribute1; + + if(transmitPayload(&protocol, payload, &as) == 0){ + printf("Packet successfully sent\n"); + } else { + printf("Failed to send packet\n"); + } + + tearDown(&protocol); + + freePeer(&peer); Review comment: It can happen, yes. Peer supports injecting socket. In case there is no socket injected (for eg.: the case above), peer created the internal socket based on the host and the port. In this case peer owns the socket, so closes and calls free. On naming, I agree it's not the best. Do you think tearDownPeer or shutDownPeer or something alike that would be more appropriate for this functionality? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
