phrocker commented on issue #550: MINIFICPP-822 - Nanofi raw S2S implementation shouldn't depend on any… URL: https://github.com/apache/nifi-minifi-cpp/pull/550#issuecomment-490489017 I took a quick glance and everything looked good at face value. Some minor comments I'll release when I take a better look; however, my biggest concern is if we can, in time, easily replace this in the C++ Client. Not that I necessarily want to move everything to C, but having the agent rely on nanofi would be nice so we can reduce the amount of maintained code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services