arpadboda edited a comment on issue #554: MINIFICPP-842 - CivetWeb tests should use random port URL: https://github.com/apache/nifi-minifi-cpp/pull/554#issuecomment-493000224 > Was about to merge and realized that SKIP_TESTS is used as the ifdef. The logic there is that if tests are built include this parameter. This means that RandomPort will be included via the manifest if tests were built. Could you just set listening port to zero via the config of the test, use the function to get the port you added to later config the client? This way no randomport option is needed. The same port config is used. That was my initial idea as well, although the port validator we have at the moment doesn't accept 0, so that wouldn't work. Which makes sense in a way as 0 is not a valid port. We could make that a global rule in MiNiFi - port validator allows 0 and that means the processor has to choose a random free port. We might consider this in the future, but it's a breaking change and clearly doesn't fit the scope of this ticket. This would also mean separating port validator to target and listen ports as a target port (where we attempt to connect to) still shouldn't be zero.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
