phrocker opened a new pull request #555: MINIFICPP-280: Adding extension linters URL: https://github.com/apache/nifi-minifi-cpp/pull/555 Based entirely upon prior work of calebj in https://github.com/apache/nifi-minifi-cpp/pull/168 He gets full credit for this, but since I'm applying the work to a different branch we can't just pull the commits. Original message: MINIFI-280 Move extension tests and headers, lint extensions move extension tests into their respective folders separate source and header files remove unnecessary or nonexisting include directories run linter on extension source files as part of linter target clean up extensions according to linter add ability to specify more than one include and source folder for linter @calebj We moved standard processors to their own extension, so now to get our linting back I've applied your work. I will slowly add the linter to other extensions and at some point make it a required part of submitting an extension I didn't forget! Thanks for your hard work there Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
