bakaid commented on a change in pull request #563: WiP: MINIFICPP-839 - Fix
memleaks
URL: https://github.com/apache/nifi-minifi-cpp/pull/563#discussion_r286042867
##########
File path: libminifi/src/core/Processor.cpp
##########
@@ -176,7 +176,7 @@ void
Processor::removeConnection(std::shared_ptr<Connectable> conn) {
// Connection is destination to the current processor
if (_incomingConnections.find(connection) != _incomingConnections.end()) {
_incomingConnections.erase(connection);
- connection->setDestination(NULL);
Review comment:
I prefer nullptr too, but setDestination now gets a weak_ptr and weak_ptr
has no constructor from nullptr_t (or any pointer for that matter).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
