phrocker commented on a change in pull request #577: MINIFICPP-904: Switch to 
get_separator() in MiNiFi Main
URL: https://github.com/apache/nifi-minifi-cpp/pull/577#discussion_r289408907
 
 

 ##########
 File path: main/Main.h
 ##########
 @@ -128,7 +123,7 @@ extern "C" {
 bool validHome(const std::string &home_path) {
   struct stat stat_result { };
   std::string sep;
-  sep += FILE_SEPARATOR;
+  sep += utils::file::FileUtils::get_separator();
 
 Review comment:
   I think the answer to why was that I didn't notice when I was extracting 
various commits across different branches and auto submitted the PRs via the 
CLI. Thanks!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to