bbende commented on a change in pull request #3523: NIFI-6325 Adds support for
AWS KMS Sensitive Property Provider.
URL: https://github.com/apache/nifi/pull/3523#discussion_r292984675
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/pom.xml
##########
@@ -26,11 +26,19 @@
performs any decryption/retrieval of sensitive configuration
properties.
</description>
<packaging>jar</packaging>
+ <properties>
+ <aws-java-sdk-version>1.11.461</aws-java-sdk-version>
+ </properties>
<dependencies>
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-properties</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.amazonaws</groupId>
+ <artifactId>aws-java-sdk-kms</artifactId>
+ <version>${aws-java-sdk-version}</version>
+ </dependency>
Review comment:
Just a minor note that we'll need to consider if anything needs to be added
to the LICENSE/NOTICE in nifi-assembly and in nifi-framework-nar, for this new
dependency and any new transitive dependencies it brings in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
