kevdoran commented on a change in pull request #197: NIFIREG-206 Support
anonymous access to public resources
URL: https://github.com/apache/nifi-registry/pull/197#discussion_r293416465
##########
File path:
nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/AuthorizationService.java
##########
@@ -461,6 +462,16 @@ public AccessPolicy deleteAccessPolicy(String identifier)
{
.map(AuthorizationService::resourceToDTO)
.collect(Collectors.toList());
+ // add any buckets that have been made public for read requests
Review comment:
So it looks like to me that now the `getBucketsAllowingPublicRead()` methods
that were added to `RegistryService` and `MetadataService` are no longer
needed, as this was the only place they was used (aside from test code). Do you
want to leave it or remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
