alopresto commented on a change in pull request #3542: NIFI-6363 Integrates AWS
KMS SPP. Refactors SSPP.
URL: https://github.com/apache/nifi/pull/3542#discussion_r296364937
##########
File path:
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy
##########
@@ -1091,7 +1095,7 @@ class ConfigEncryptionTool {
encryptedProperties.setProperty(key,
plainProperties.getProperty(key))
}
NiFiProperties mergedProperties = new
StandardNiFiProperties(encryptedProperties)
- logger.info("Final result: ${mergedProperties.size()} keys including
${ProtectedNiFiProperties.countProtectedProperties(mergedProperties)} protected
keys")
+ logger.info("Final result: ${mergedProperties.size()} keys including
${ProtectedNiFiProperties.countProtectedProperties(mergedProperties, keyHex)}
protected keys")
Review comment:
I think the implementation of
`ProtectedNiFiProperties#countProtectedProperties()` needs to change so that it
doesn't require the key hex or ID in order to count the protected properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
