arpadboda commented on a change in pull request #597: MINIFICPP-933: Fix raw
site to site with secure comms
URL: https://github.com/apache/nifi-minifi-cpp/pull/597#discussion_r297711955
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -105,7 +105,8 @@ class StringUtils {
* @param s incoming string
* @returns modified string
*/
- static inline std::string trimLeft(std::string s) {
+ static inline std::string trimLeft(const std::string &in_string) {
+ auto s = in_string;
Review comment:
What's the motivation behind this change?
I think the behaviour didn't change at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
