mcgilman commented on a change in pull request #3536: NIFI-6380: Introduced the
notion of Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#discussion_r298638610
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/StandardAuthorizableLookup.java
##########
@@ -158,6 +159,18 @@ public Resource getResource() {
}
};
+ private static final Authorizable PARAMETER_CONTEXTS_AUTHORIZABLE = new
Authorizable() {
+ @Override
+ public Authorizable getParentAuthorizable() {
+ return null;
Review comment:
I think the parameter context authorizable should have a parent authorizable
of the controller authorizable. I believe feature proposal indicates the
parameter contexts would exist at the controller level. By having the
controller be the parent authorizable, anyone with access to the controller
will automatically have access to the parameter contexts (unless overridden by
a specific parameter context policy). By also introducing the parameter context
authorizable (which you've done), we provide the ability to allow someone to
manage parameters without also giving them access to the controller settings.
By implementing this, it would also make migration easier as the users will
not have to manually build out the new policies (since seeding only happens on
initial startup). Additionally, we could remove the code that seeds the
parameter context policies as we are already seeding policies for the
controller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
