ijokarumawak commented on a change in pull request #3575: NIFI-6271, fix
incoming flowfile attributes don't copy into output flowfiles when Output Batch
Size is set
URL: https://github.com/apache/nifi/pull/3575#discussion_r300921724
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
##########
@@ -312,12 +312,6 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
// If we've reached the batch size, send out
the flow files
if (outputBatchSize > 0 &&
resultSetFlowFiles.size() >= outputBatchSize) {
session.transfer(resultSetFlowFiles,
REL_SUCCESS);
- // Need to remove the original input file
if it exists
- if (fileToProcess != null) {
- session.remove(fileToProcess);
- fileToProcess = null;
- }
- session.commit();
Review comment:
We can't remove this `session.commit()` because this is required when
'Output Batch Size' is higher than 0. The purpose is committing FlowFiles
before iterating through whole result set so that downstream flow can process
those gradually.
Also, the `if (fileToProcess != null) {` block is required to address
NIFI-6040. This PR doesn't have the issue reported by NIFI-6040 because it also
removes the `session.commit()`.
I think the correct solution is removing the only line 318, `fileToProcess =
null;`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
