jtstorck commented on a change in pull request #3404: [WIP] NIFI-5176 Java 11
Build Compatibilty
URL: https://github.com/apache/nifi/pull/3404#discussion_r303165738
##########
File path:
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
##########
@@ -888,7 +888,7 @@ public SSLContext getSslContext() {
if (keyManagerFactory != null && trustManagerFactory != null) {
try {
// initialize the ssl context
- final SSLContext sslContext =
SSLContext.getInstance("TLS");
+ final SSLContext sslContext =
SSLContext.getInstance("TLSv1.2"); // FIXME TLSv1.3 not working under Java 11,
setting explicitly to TLSv1.2 works.
Review comment:
I'll do some testing locally after making the dependency updates. If the
tests pass with JDK 11.0.3, then I think it's reasonable to document that as
the minimum version for Java 11 builds.
Thanks for looking into this, @ijokarumawak!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
