ijokarumawak opened a new pull request #3583: NIFI-5970 Handle multiple input FlowFiles at Put.initConnection URL: https://github.com/apache/nifi/pull/3583 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: #### Description of PR - Adding FlowFileFilter provider at DBCPService interface, so that processors can filter input FlowFiles based on service specific rules. - Implemented filtering rule at DBCPConnectionPoolLookup to guarantee all input FlowFiles have the same 'database.name' attribute. - Changed Put.initConnection from using a single FlowFile to a list of FlowFiles, so that each implementation can handle connection establishment with multiple FlowFiles correctly. - NOTE: Put.initConnection didn't use any FlowFile if there're more than 1 FlowFiles fetched. This PR changed that behavior but it should be fine since PutSQL is the only implementation that allows multiple incoming FlowFiles. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)? - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
