[ 
https://issues.apache.org/jira/browse/MINIFICPP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892887#comment-16892887
 ] 

Arpad Boda commented on MINIFICPP-985:
--------------------------------------

[~phrocker] theoretically we could in property as there is a collection mode of 
properties, where this could be done, although:

-This isn't exposed to the test framework, we can't even verify

-This member of properties are not part of the agent manifest, so it's 
impossible via C2. Also setting multiple values would require changes in C2 
communication. 

-Even if we fix the above two, ListValidators provide more, like a property can 
be a set of integers. In this case we can't list allowable values, but Integer 
validator is not enough to cover this. 

 

What you mentioned (4 and 3.3) is something I definitely DON'T plan to support 
this way, only multiple values of one type, where the validation doesn't become 
complex: just tokenising the value and validating the tokens using one 
encapsulated validator. I think it's very low risk and low impact (~15 lines of 
new code + tests),

> Implement listvalidators
> ------------------------
>
>                 Key: MINIFICPP-985
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-985
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: New Feature
>    Affects Versions: 0.6.0
>            Reporter: Arpad Boda
>            Assignee: Arpad Boda
>            Priority: Major
>             Fix For: 0.7.0
>
>
> As [~nghiaxlee] pointed out in a change we don't have the functionality to 
> create list validators (in which case all elements of the input lists should 
> be validated using an encapsulated validator), so we can't validate multiple 
> choice properties for eg. 
> The change itself is quite easy, although we should keep in mind C2 
> integration. Because of this [~phrocker] and [~kdoran] I would like to ask 
> for your feedback on adding this into agent manifest. Thanks in advance!
> I scoped this for 0.7.0 as the MiNiFi impact would be small, however I can 
> accept rescheduling it to 0.8.0 in case C2 integration requires more effort 
> and testing.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to