phrocker commented on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-515492387 @nghiaxlee Sorry i missed the notifications. Allow me to answer the questions in reverse order. I presented my chief concern, which is the sanctity of environment variables that are set externally. Before I begin can I ask that you agree with the following: 1) Environment variables can be set via the command line that are different than what you are setting in the initializer? 2) Python processors can be written a posteriori that set these env variables ( they shouldn't but *may* happen )? With these agreed upon, my chief concern is dealing with that. Are you and @arpadboda suggesting that is not a concern? "About the python processor, if I set the variable in the Initializer construct, then it will be called at the very beginning, so it should not affect the processors." We cannot guarantee the order of initializer execution amongst various extensions. Even if that were to become true you can't guarantee the user hasn't set something before your initializers are called. Putting the onus externally improves configuration management. Why should we require that users re-compile a binary to achieve change in an environment variable. "Can you give me more detail about the shell script approach? Like why is it good" I'm sorry if I relayed this as a "good" approach. I never meant to suggest that, but that it is the lesser of two evils. We put the onus on the user OR at the very least we provide the consumer with the ability to make changes. My comment about check and set is an option, but my only goal is to avoid these conflicting settings. Are these not a concern? Happy to hear a disagreement on the tenets I've laid out here and previously.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
