am-c-p-p commented on a change in pull request #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307828769
########## File path: extensions/libmodbus/Libmodbus.vcxproj ########## @@ -0,0 +1,188 @@ +<?xml version="1.0" encoding="utf-8"?> Review comment: It is not a derivative, I created it. The one in repo has modbus.vcproj. After conversion to VS2017 format, IDE creates modbus.vsxproj from modbus.vcproj. I created a new project Libmodbus.vsxproj and added files which are in modbus.vsxproj and set the same `C` macros as in modbus.vsxproj. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
