jtstorck commented on issue #3404: NIFI-5176 Java 11 Build Compatibilty URL: https://github.com/apache/nifi/pull/3404#issuecomment-517135360 > @jtstorck should `-Dmaven.surefire.arguments=-Duser.timezone=UTC` be baked into the build at this point? It shouldn't. Since that issue is outside of this PR, I don't think a workaround should be committed in this PR. I'm tempted to remove the changes for the Travis build from this PR as well, so that the PR isn't held up by Travis failures. I have another branch in which I was working on getting the build to pass on Travis with Java 11, but there are some issues with the time it takes to complete the build. The caching on Travis isn't working as I'd expect, and all the dependencies need to be downloaded for each Java 11 build. If I remove the Travis changes from this PR, Travis would continue to build master with Java 8 only. I'd submit a follow-on PR for the Java 11 build on Travis. > Need to update the Dockerfiles to use Java 11 base images, but other than that +1. I'd like to keep the docker builds set to use Java 8 since the convenience binaries released are built with Java 8, until the minimum version of Java for NiFi is moved to Java 11. Does anyone have specific issues with either of the above comments? @alopresto, if you are a +1 on the Toolkit-related changes, then it looks like the PR is in a good spot to be merged, once the Travis concerns are either fixed or removed from this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
