adarmiento commented on a change in pull request #3634: NIFI-6524 MergeContent
properties should accept expression language variables
URL: https://github.com/apache/nifi/pull/3634#discussion_r310765480
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestMergeContent.java
##########
@@ -1153,6 +1153,248 @@ public void testMaxBinAge() throws
InterruptedException {
runner.run();
runner.assertTransferCount(MergeContent.REL_MERGED, 1);
+
+ runner = TestRunners.newTestRunner(new MergeContent());
Review comment:
Should I only check the EL values are correctly evaluated, or also that the
processor works when using the EL attributes? I found the tests redundant too,
but I wasn't sure about checking only that the `evaluateExpression()` worked as
expected was enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
