[
https://issues.apache.org/jira/browse/NIFI-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905535#comment-16905535
]
Joseph Witt commented on NIFI-4775:
-----------------------------------
Regarding my concern that this wasn't reviewed by a committer and has already
been committed...we've never really formalized the view. But in general the
opinion seems to be this is allowed.
https://lists.apache.org/thread.html/8562e182af3673bee0dfb567b2436693d9e3a00f98346575d8def4a6@%3Cdev.nifi.apache.org%3E
So please ignore that concern for now. I am focused on the others though
> Allow FlowFile Repository to optionally perform fsync when writing CREATE
> events but not other events
> -----------------------------------------------------------------------------------------------------
>
> Key: NIFI-4775
> URL: https://issues.apache.org/jira/browse/NIFI-4775
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Brandon DeVries
> Priority: Major
> Fix For: 1.10.0
>
> Attachments: RocksDBFlowFileRepo.html, rocksdb-flowfile-repo.adoc
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, when a FlowFile is written to the FlowFile Repository, the repo
> can either fsync or not, depending on nifi.properties. We should allow a
> third option, of fsync only for CREATE events. In this case, if we receive
> new data from a source we can fsync the update to the FlowFile Repository
> before ACK'ing the data from the source. This allows us to guarantee data
> persistence without the overhead of an fsync for every FlowFile Repository
> update.
> It may make sense, though, to be a bit more selective about when do this. For
> example if the source is a system that does not allow us to acknowledge the
> receipt of data, such as a ListenUDP processor, this doesn't really buy us
> much. In such a case, we could be smart about avoiding the high cost of an
> fsync. However, for something like GetSFTP where we have to remove the file
> in order to 'acknowledge receipt' we can ensure that we wait for the fsync
> before proceeding.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
