bakaid commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety URL: https://github.com/apache/nifi-minifi-cpp/pull/621#discussion_r314647065
########## File path: extensions/librdkafka/PublishKafka.cpp ########## @@ -319,27 +320,29 @@ void PublishKafka::onTrigger(const std::shared_ptr<core::ProcessContext> &contex std::string client_id, brokers, topic; + std::unique_ptr<KafkaLease> lease = nullptr; Review comment: This is purely stylistic, but the default constructor of `std::unique_ptr<T>` already initializes the unique_ptr to own nothing, so assigning a `nullptr` is superfluous. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
