natural commented on a change in pull request #3637: NIFI-6400 Better options,
consistent ids for ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3637#discussion_r318110860
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-shell-authorizer/src/main/java/org/apache/nifi/authorization/ShellUserGroupProvider.java
##########
@@ -499,12 +522,13 @@ private void rebuildGroups(List<String> groupLines,
Map<String, Group> groupsByI
logger.error("list membership shell exception: " + ioexc);
}
- if (name != null && id != null && !name.equals("") &&
!id.equals("")) {
- Group group = new
Group.Builder().name(name).identifier(id).addUsers(users).build();
- groupsById.put(id, group);
+ if (name != null && id != null && !name.equals("") &&
!id.equals("") && !excludeGroups.matcher(name).matches()) {
+ String groupIdentifier = getNameBasedUUID(id);
+ Group group = new
Group.Builder().name(name).identifier(groupIdentifier).addUsers(users).build();
Review comment:
Yes -- updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
