apiri commented on a change in pull request #630: MINIFICPP-1006: minor updates
for jni building using win build & correct artifact naming
URL: https://github.com/apache/nifi-minifi-cpp/pull/630#discussion_r318224083
##########
File path: extensions/windows-event-log/CMakeLists.txt
##########
@@ -30,10 +30,27 @@ if(CMAKE_THREAD_LIBS_INIT)
target_link_libraries(minifi-wel "${CMAKE_THREAD_LIBS_INIT}")
endif()
+set(PUGI_BYPRODUCT_DIR
"${CMAKE_CURRENT_BINARY_DIR}/thirdparty/pugixml-install" CACHE STRING "PugiXML
install directory")
+set(BYPRODUCT "${PUGI_BYPRODUCT_DIR}/lib/pugixml.lib")
+ ExternalProject_Add(
+ pugixml-external
+ GIT_REPOSITORY "https://github.com/zeux/pugixml.git";
Review comment:
I don't see this in license. Looks like NOTICE isn't needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
