arpadboda edited a comment on issue #636: Minificpp-780 - Change GenerateFlowFile to allow 0b content FlowFiles URL: https://github.com/apache/nifi-minifi-cpp/pull/636#issuecomment-526239247 While checking this processor I found the following issues: -In case batch count is greater than one, the flowfiles generated in one batch are not unique -Handling of 0B size was error-prone: allocating zero size arrays, passing null pointers to callbacks, etc -A potential memory segmentation violation in case the file size is not multiple of 4. Because of these it was easier to completely rewrite the logic than fixing it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
