tpalfy commented on a change in pull request #3679: NIFI-6089 Add Parquet
record reader and writer
URL: https://github.com/apache/nifi/pull/3679#discussion_r319080359
##########
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/record/listen/StandardSocketChannelRecordReader.java
##########
@@ -48,13 +48,13 @@ public StandardSocketChannelRecordReader(final
SocketChannel socketChannel,
}
@Override
- public RecordReader createRecordReader(final FlowFile flowFile, final
ComponentLog logger) throws IOException, MalformedRecordException,
SchemaNotFoundException {
+ public RecordReader createRecordReader(final ComponentLog logger) throws
IOException, MalformedRecordException, SchemaNotFoundException {
if (recordReader != null) {
Review comment:
Shouldn't this recordReader be created in the constructor (as the interface
before the change has alluded to)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
