bbende commented on a change in pull request #3679: NIFI-6089 Add Parquet record reader and writer URL: https://github.com/apache/nifi/pull/3679#discussion_r319207206
########## File path: nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java ########## @@ -96,18 +97,40 @@ .allowableValues(org.apache.parquet.column.ParquetProperties.WriterVersion.values()) .build(); - public static List<AllowableValue> COMPRESSION_TYPES = getCompressionTypes(); + public static final PropertyDescriptor AVRO_READ_COMPATIBILITY = new PropertyDescriptor.Builder() + .name("avro-read-compatibility") + .displayName("Avro Read Compatibility") + .description("Specifies the value for 'parquet.avro.compatible' in the underlying Parquet library") + .allowableValues("true", "false") + .defaultValue("true") + .required(true) + .build(); - public static final PropertyDescriptor COMPRESSION_TYPE = new PropertyDescriptor.Builder() - .name("compression-type") - .displayName("Compression Type") - .description("The type of compression for the file being written.") - .allowableValues(COMPRESSION_TYPES.toArray(new AllowableValue[0])) - .defaultValue(COMPRESSION_TYPES.get(0).getValue()) + public static final String PARQUET_AVRO_ADD_LIST_ELEMENT_RECORDS = "parquet.avro.add-list-element-records"; + + public static final PropertyDescriptor AVRO_ADD_LIST_ELEMENT_RECORDS = new PropertyDescriptor.Builder() + .name("avro-add-list-element-records") + .displayName("Avro Add List Element Records") + .description("Specifies the value for 'parquet.avro.add-list-element-records' in the underlying Parquet library") + .allowableValues("true", "false") + .defaultValue("true") + .required(true) + .build(); + + public static final String PARQUET_AVRO_WRITE_OLD_LIST_STRUCTURE = "parquet.avro.write-old-list-structure"; + + public static final PropertyDescriptor AVRO_WRITE_OLD_LIST_STRUCTURE = new PropertyDescriptor.Builder() + .name("avro-write-old-list-structure") + .displayName("Avro Write Old List Structure") + .description("Specifies the value for 'parquet.avro.write-old-list-structure' in the underlying Parquet library") + .allowableValues("true", "false") + .defaultValue("true") .required(true) .build(); - public static List<AllowableValue> getCompressionTypes() { + public static List<AllowableValue> COMPRESSION_TYPES = getCompressionTypes(); Review comment: Will update ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services