jzonthemtn commented on a change in pull request #168: MINIFI-512 Change bootstrap port command handling URL: https://github.com/apache/nifi-minifi/pull/168#discussion_r323469127
########## File path: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java ########## @@ -1562,6 +1564,12 @@ void setAutoRestartNiFi(final boolean restart) { } void setMiNiFiCommandControlPort(final int port, final String secretKey) throws IOException { + + if (this.secretKey != null && this.ccPort != UNINITIALIZED_CC_PORT) { Review comment: Just wondering if these will always be set together, or would `||` be more appropriate? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services