arpadboda commented on a change in pull request #650: MINIFICPP-1034 - MQTT
processors doesnt work
URL: https://github.com/apache/nifi-minifi-cpp/pull/650#discussion_r326549739
##########
File path: extensions/mqtt/processors/AbstractMQTTProcessor.h
##########
@@ -28,16 +28,16 @@
#include "core/logging/LoggerConfiguration.h"
#include "MQTTClient.h"
-#define MQTT_QOS_0 "0"
-#define MQTT_QOS_1 "1"
-#define MQTT_QOS_2 "2"
-
namespace org {
namespace apache {
namespace nifi {
namespace minifi {
namespace processors {
+#define MQTT_QOS_0 "0"
Review comment:
Just wanted to put the definitions together, but constexpr is a fair point.
Changed them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
