MikeThomsen commented on a change in pull request #3716: Adding infinispan processor URL: https://github.com/apache/nifi/pull/3716#discussion_r327099321
########## File path: nifi-nar-bundles/nifi-infinispan-bundle/nifi-putInInfinispanCache-processors/src/main/java/com/nifi/infinispancache/processors/putInInfinispanCache/PutInInfinispanCache.java ########## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.nifi.infinispancache.processors.putInInfinispanCache; + +import org.apache.nifi.annotation.behavior.*; +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.annotation.lifecycle.OnScheduled; +import org.apache.nifi.annotation.lifecycle.OnStopped; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.expression.AttributeExpression; +import org.apache.nifi.expression.ExpressionLanguageScope; +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.logging.ComponentLog; +import org.apache.nifi.processor.*; +import org.apache.nifi.processor.exception.ProcessException; +import org.apache.nifi.processor.util.FlowFileFilters; +import org.apache.nifi.processor.util.StandardValidators; +import org.infinispan.client.hotrod.RemoteCache; +import org.infinispan.client.hotrod.RemoteCacheManager; +import org.infinispan.client.hotrod.configuration.ConfigurationBuilder; +import org.infinispan.client.hotrod.configuration.ServerConfigurationBuilder; + +import java.io.ByteArrayOutputStream; +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +@SupportsBatching +@Tags({"Infinispan", "Cache", "Put"}) +@CapabilityDescription("Puts key-value in Infinispan cache") +@ReadsAttributes({@ReadsAttribute(attribute = "", description = "")}) +@WritesAttributes({@WritesAttribute(attribute = "", description = "")}) +@DynamicProperty(name = "Infinispan host property.", value = "Infinispan Port configuration property.", + description = "These properties will be added on the Infinispan configuration after loading any provided configuration properties." + + " In the event a dynamic property represents a property that was already set, its value will be ignored and WARN message logged.", + expressionLanguageScope = ExpressionLanguageScope.VARIABLE_REGISTRY) +public class PutInInfinispanCache extends AbstractProcessor { + + public static final PropertyDescriptor INFINISPAN_HOST = new PropertyDescriptor.Builder() + .name("Infinispan Host") + .description("Infinispan Host") + .required(true) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY) + .build(); + + public static final PropertyDescriptor INFINISPAN_PORT = new PropertyDescriptor.Builder() + .name("Infinispan Port") + .description("Infinispan Port") + .required(true) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY) + .build(); + + public static final PropertyDescriptor CACHE_NAME = new PropertyDescriptor.Builder() + .name("Cache Name") + .description("Cache Name") + .required(true) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY) + .build(); + + public static final PropertyDescriptor CACHE_KEY = new PropertyDescriptor.Builder() + .name("Cache Key") + .description("Cache Key") + .required(true) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) + .build(); + + public static final PropertyDescriptor CACHE_VALUE = new PropertyDescriptor.Builder() + .name("Cache Value") + .description("Cache Value") + .required(true) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) + .build(); + + public static final Relationship REL_SUCCESS = new Relationship.Builder() + .name("success") + .description("All FlowFiles that are created are routed to this relationship") + .build(); + + public static final Relationship REL_FAILURE = new Relationship.Builder() + .name("failure") + .description("Any FlowFiles that cannot be enriched are routed to this relationship") + .build(); + + private List<PropertyDescriptor> descriptors; + + private Set<Relationship> relationships; + + RemoteCacheManager cacheManager = null; + RemoteCache cache = null; + + @OnScheduled + public void createInfinispanPool(final ProcessContext context) { + final ComponentLog logger = getLogger(); + try { + final String host = context.getProperty(INFINISPAN_HOST).evaluateAttributeExpressions().getValue(); + final int port = Integer.parseInt(context.getProperty(INFINISPAN_PORT).evaluateAttributeExpressions().getValue()); + final String cacheName = context.getProperty(CACHE_NAME).evaluateAttributeExpressions().getValue(); + ServerConfigurationBuilder configuration = new ConfigurationBuilder().addServer().host(host).port(port); + cacheManager = new RemoteCacheManager(configuration.socketTimeout(150000).build()); + cache = cacheManager.getCache(cacheName); + } catch (Exception e) { + logger.error(e.getMessage()); + } + } + + @OnStopped + public void closeInifinispanPool(final ProcessContext context) { + final ComponentLog logger = getLogger(); + try { + if (cache != null) { + cache.stop(); + } + + if (cacheManager != null) { + cacheManager.close(); + } + } catch (Exception e) { + logger.error(e.getMessage()); + } + } + + @Override + public Set<Relationship> getRelationships() { + final Set<Relationship> relationships = new HashSet<>(2); + relationships.add(REL_SUCCESS); + relationships.add(REL_FAILURE); + return relationships; + } + + @Override + public final List<PropertyDescriptor> getSupportedPropertyDescriptors() { + final List<PropertyDescriptor> descriptors = new ArrayList<>(); + descriptors.add(INFINISPAN_HOST); + descriptors.add(INFINISPAN_PORT); + descriptors.add(CACHE_NAME); + descriptors.add(CACHE_KEY); + descriptors.add(CACHE_VALUE); + return descriptors; + } + + @Override + public void onTrigger(final ProcessContext context, final ProcessSession session) throws ProcessException { + final ComponentLog logger = getLogger(); + final List<FlowFile> flowFiles = session.get(FlowFileFilters.newSizeBasedFilter(1, DataUnit.MB, 100)); + try { + if (flowFiles.isEmpty()) { + return; + } + for (FlowFile flowFile : flowFiles) { + final String cacheKey = context.getProperty(CACHE_KEY).evaluateAttributeExpressions(flowFile).getValue(); + String cacheValue = null; + cacheValue = context.getProperty(CACHE_VALUE).evaluateAttributeExpressions(flowFile).getValue(); + if (".*".equalsIgnoreCase(cacheValue.trim())) { + final ByteArrayOutputStream bytes = new ByteArrayOutputStream(); + session.exportTo(flowFile, bytes); + cacheValue = bytes.toString(); Review comment: I don't think this operation is going to be a safe way to serialize the byte array. What do you think @pvillard31? My inclination would be to base64 encode the byte array if a string representation is what the cache needs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
