bakaid commented on a change in pull request #635: MINIFICPP-819 - OPC Unified Architecture Support URL: https://github.com/apache/nifi-minifi-cpp/pull/635#discussion_r330416285
########## File path: extensions/opc/include/fetchopc.h ########## @@ -0,0 +1,109 @@ +/** + * FetchOPC class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef NIFI_MINIFI_CPP_FetchOPCProcessor_H +#define NIFI_MINIFI_CPP_FetchOPCProcessor_H + +#include <memory> +#include <string> +#include <list> +#include <map> +#include <mutex> +#include <thread> + +#include "opc.h" +#include "opcbase.h" +#include "utils/ByteArrayCallback.h" +#include "FlowFileRecord.h" +#include "core/Processor.h" +#include "core/ProcessSession.h" +#include "core/Core.h" +#include "core/Property.h" +#include "core/Resource.h" +#include "controllers/SSLContextService.h" +#include "core/logging/LoggerConfiguration.h" +#include "utils/Id.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace processors { + +class FetchOPCProcessor : public BaseOPCProcessor { +public: + static constexpr char const* ProcessorName = "FetchOPC"; + // Supported Properties + static core::Property NodeIDType; + static core::Property NodeID; + static core::Property NameSpaceIndex; + static core::Property MaxDepth; + + // Supported Relationships + static core::Relationship Success; + static core::Relationship Failure; + + FetchOPCProcessor(std::string name, utils::Identifier uuid = utils::Identifier()) Review comment: Please initialize the integral type members to 0 in the constructor. I know that we fill them in onSchedule, but a mistake in a future rewrite could change that, so I would like to be defensive here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
