joewitt commented on a change in pull request #3676: NIFI-6597 Azure Event Hub
Version Update
URL: https://github.com/apache/nifi/pull/3676#discussion_r333127836
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/GetAzureEventHub.java
##########
@@ -198,16 +201,16 @@
return propertyDescriptors;
}
-
- protected void setupReceiver(final String connectionString) throws
ProcessException {
+ protected void setupReceiver(final String connectionString, final
ScheduledExecutorService executor) throws ProcessException {
try {
- eventHubClient =
EventHubClient.createFromConnectionString(connectionString).get();
- } catch (InterruptedException | ExecutionException | IOException |
ServiceBusException e) {
+ EventHubClientImpl.USER_AGENT = "ApacheNifi-azureeventhub/2.3.2";
Review comment:
@mysunnytime ApacheNiFi (not the capitalized F). I realize that seems
unimportant but either it should be all lowercase or it should follow
convention which is NiFi (not Nifi). So either do
'apachenifi-azureeventhub/2.3.2" or do 'ApacheNiFi-azureeventhub/2.3.2' . I
prefer the NiFi convention but either is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
