arpadboda edited a comment on issue #666: MINIFICPP-1070 - Fixed handling of PKCS12 certificates URL: https://github.com/apache/nifi-minifi-cpp/pull/666#issuecomment-545883300 Looks good, will merge soon, thanks! @asdaraujo : next time please take a look at linter errors! (You can run linter by executing "make linter"). Will fix the current ones when merging. ``` /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:101: An else should appear on the same line as the preceding } [whitespace/newline] [4] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:101: If an else has a brace on one side, it should have it on both [readability/braces] [5] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:31: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:73: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:87: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:88: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:89: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:90: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:91: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:92: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:93: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//controllers/SSLContextService.cpp:94: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1] ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
