ekovacs commented on issue #245: NIFIREG-252: adding mavendocker build profile
URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-545966491
 
 
   > Yeah, good points. I would support moving 
nifi-registry-core/nifi-registry-docker to a top level module that is 
responsible for both dockerhub and dockermaven. Do you think we should do that 
now or save that improvement for later?
   
   
   currently `nifi-registry/nifi-registry-core/nifi-registry-docker/dockerhub` 
is not a maven project (no pom.xml in its folder) this is another difference 
between the NiFi dockerhub and the NiFi Registry counter part. if we were to 
move it out from under the `nifi-registry-core` hierarchy, i'd also go for 
turning it into a maven project. 
   
   If it is OK with you, i'd rather file a separate Jira / PR for that move & 
mavenization, to keep this PR small & single-work-item-focused.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to