turcsanyip commented on a change in pull request #3858: NIFI-6032 CDC for Oracle using xstream URL: https://github.com/apache/nifi/pull/3858#discussion_r342548039
########## File path: nifi-nar-bundles/nifi-oraclecdc-bundle/nifi-oraclecdc-processors/src/main/java/org/apache/nifi/processors/oraclecdc/controller/impl/StandardOracleCDCService.java ########## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.oraclecdc.controller.impl; + +import java.lang.reflect.Method; +import java.lang.reflect.Proxy; +import java.sql.Connection; +import java.sql.SQLException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; + +import org.apache.commons.codec.binary.Base32; +import org.apache.commons.dbcp2.BasicDataSource; +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.annotation.lifecycle.OnEnabled; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.controller.AbstractControllerService; +import org.apache.nifi.controller.ConfigurationContext; +import org.apache.nifi.expression.AttributeExpression; +import org.apache.nifi.expression.ExpressionLanguageScope; +import org.apache.nifi.processor.exception.ProcessException; +import org.apache.nifi.processor.util.StandardValidators; +import org.apache.nifi.processors.oraclecdc.utils.LCRCallBackHandler; +import org.apache.nifi.reporting.InitializationException; +import org.nifi.oraclecdcservice.api.OracleCDCEventHandler; +import org.nifi.oraclecdcservice.api.OracleCDCService; +import org.nifi.oraclecdcservice.api.OracleClassLoaderService; + +@Tags({ "dbcp", "jdbc", "database", "cdc", "oracle", "store" }) +@CapabilityDescription("Provides Database Connection Pooling Service for oracle CDC connection." + + " Needs OCI native connection. Add the location to the native libraries using -Djava.library.path" + + "to the jvm argurmets in nifi bootstrap.conf") + +public class StandardOracleCDCService extends AbstractControllerService implements OracleCDCService { + + public static final PropertyDescriptor DB_HOST = new PropertyDescriptor.Builder().name("DB_HOST") Review comment: Please use the same convention for the property names within a class: DB_HOST vs dbcp-min-idle-conns I think the latter is the preferred way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
