phrocker commented on a change in pull request #683: MINIFICPP-1087 - Proper handling of errors during onSchedule calls URL: https://github.com/apache/nifi-minifi-cpp/pull/683#discussion_r350804604
########## File path: libminifi/src/core/ProcessGroup.cpp ########## @@ -136,13 +147,14 @@ void ProcessGroup::removeProcessGroup(ProcessGroup *child) { } } -void ProcessGroup::startProcessing(const std::shared_ptr<TimerDrivenSchedulingAgent> timeScheduler, const std::shared_ptr<EventDrivenSchedulingAgent> &eventScheduler, - const std::shared_ptr<CronDrivenSchedulingAgent> &cronScheduler) { +void ProcessGroup::startProcessingProcessors(const std::shared_ptr<TimerDrivenSchedulingAgent> timeScheduler, Review comment: line lengths are 200 fyi. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services